svn commit: r272282 - head/share/mk

Will Andrews will at firepipe.net
Wed Oct 1 20:16:53 UTC 2014


On Wed, Oct 1, 2014 at 2:03 PM, NGie Cooper <yaneurabeya at gmail.com> wrote:
> This change seems like it introduces a lot of unnecessary complexity
> in lieu of someone setting PORTSDIR to the root of their ports tree in
> the environment.

Sure, but people that are trying to use it somewhere other than
/usr/ports shouldn't be surprised by misbehavior.  I've worked with
several people (who aren't steeped in the usage of ports) who were
astonished by this behavior.

> Why isn't it using a for-loop by the way?

My original implementation used a shell for loop (see the CR), but
given the lack of a legitimate use case for looking farther up than
three parent directories, it seemed easier not to.  I suppose one
could use a static list of paths in the for loop though.

--Will.


More information about the svn-src-head mailing list