svn commit: r275241 - head/sys/boot/pc98/boot2

Hans Petter Selasky hps at selasky.org
Sat Nov 29 14:40:56 UTC 2014


On 11/29/14 13:22, Takahashi Yoshihiro wrote:
> +	    if (k = ep - arg) {

There is a missing set of parenthesis here, GCC will complain!

>  		} else if (c == 'S') {
>  		    j = 0;
> -		    while ((unsigned int)(i = *arg++ - '0') <= 9)
> +		    while ((i = *arg++ - '0') <= 9)
>  			j = j * 10 + i;
>  		    if (j > 0 && i == -'0') {
>  			comspeed = j;

Like Bruce said, this code does no longer handle negative values of "i" 
like before!

BTW: If we want to squeeze more bytes out, we should consider something 
like compressing the code, perhaps using something like Farbraush ??

--HPS



More information about the svn-src-head mailing list