svn commit: r274709 - head/sys/netpfil/pf

[Dag-Erling Smørgrav]

Ermal Luçi <eri at freebsd.org> writes:
> Also this only affects the traffic sourced by the host itself and not
> forwarded traffic and I think this patch will provide a regression for
> the issues that the committed patch does.

How?

The code as it stands (after your commit) is incorrect and will trigger
an assertion in vtnet(4).  You could argue that it is less incorrect
than the original, but the cure is worse than the disease.

My patch fixes the panic as well as two preexisting bugs (not taking the
IP checksum into account in the IPv4 path, and ignoring hardware
offloading).  See https://bugs.freebsd.org/192013#c10 for an explanation
of what it does and why.

DES
-- 
Dag-Erling Smørgrav - des at des.no