svn commit: r274200 - head/share/mk

[Alexander Kabaev]

On Sat, 08 Nov 2014 22:09:38 +0200
Andriy Gapon <avg at FreeBSD.org> wrote:

> On 08/11/2014 19:00, Alexander Kabaev wrote:
> > On Thu, 6 Nov 2014 22:46:40 +0000 (UTC) Mark Johnston
> > <markj at FreeBSD.org> wrote:
> > 
> >> Author: markj Date: Thu Nov  6 22:46:40 2014 New Revision: 274200
> >> URL: https://svnweb.freebsd.org/changeset/base/274200
> >> 
> >> Log: Automatically build with debug symbols when building with
> >> WITH_CTF. Otherwise there's nothing for ctfconvert to do, and it
> >> ends up emitting an error for each object file. Also remove some
> >> redundant checks from bsd.prog.mk and bsd.lib.mk.
> > <SKIP>
> >> 
> >> -.if ${MK_CTF} != "no" && ${DEBUG_FLAGS:M-g} != "" +.if
> >> ${MK_CTF} != "no" CTFFLAGS+= -g .endif .else
> > 
> > I have a question about this and another similar change. Does it
> > have the effect of always leaving binaries with debug symbols in id
> > WITH_CTF is in effect and do we now rely solely on install
> > stripping binaries at later stage to get rid of the debug symbols?
> > IMHO, we should only pass -g to ctfconvert if WITH_CTF is set _and_
> > user requested debug symbols explicitly. Your change seems to be
> > breaking that.
> 
> Hmm, I do not follow your logic here, sorry.
> So, you say that stripping should be ctfconvert's job? Why?
> 
> -- 
> Andriy Gapon

Because when building stuff with unwanted debug symbols one should make
sure they are really gone and the patch basically undoes than promise.
Whose job is it to strip .o's that end up in as the part of the .a
archives, for example? DEBUG_FLAGS are there for users to be able to
specify, khm, own debug flags and stuffing values in there
automatically is just wrong. Also, there are these bits in our .mk
files which I did not remember were there:

.if !defined(DEBUG_FLAGS)
STRIP?= -s
.endif

So, when present, DEBUG_FLAGS do prevent the stripping of binaries
completely, making the patch as is even more wrong that I thought
originally.

-- 
Alexander Kabaev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 173 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20141108/52510c3e/attachment.sig>