svn commit: r266349 - in head: share/mk sys/conf

[Warner Losh]

On May 18, 2014, at 1:56 PM, Andrew Turner <andrew at fubar.geek.nz> wrote:

> On Sat, 17 May 2014 20:31:34 +0000 (UTC)
> Warner Losh <imp at FreeBSD.org> wrote:
> 
>> Author: imp
>> Date: Sat May 17 20:31:34 2014
>> New Revision: 266349
>> URL: http://svnweb.freebsd.org/changeset/base/266349
>> 
>> Log:
>>  The time is not yet ripe to break the lack of dependencies between
>>  src/sys and the rest of the tree for builds.
>>  o eliminate including bsd.mkopts.mk for the moment in kern.opts.mk
>>  o No need to include src.opts.mk at all anymore. The reasons for it
>>    are now coverted in sys.mk and src.sys.mk.
> 
> This breaks ARM kernel builds as MK_ARM_EABI is undefined, at least on
> 9.x. The below patch fixes it for me.
> 
> Andrew
> 
> Index: sys/conf/kern.opts.mk
> ===================================================================
> --- sys/conf/kern.opts.mk	(revision 266414)
> +++ sys/conf/kern.opts.mk	(working copy)
> @@ -16,6 +16,7 @@
> # src tree.
> 
> __DEFAULT_YES_OPTIONS = \
> +    ARM_EABI \
>     FORMAT_EXTENSIONS \
>     KERNEL_SYMBOLS


Yea, this will fix it. I’ll commit the fix.

But do we support (and have it work) building !EABI for ARM? If not, it should be retired from the tree because it really is an ABI affecting make option, of which there should be zero. If we want to support arm + oabi, then that will need a new uname. I don’t think we do, but we could easily make armeb the only one to do this...

Warner