svn commit: r265472 - head/bin/dd

[Alan Somers]

On Thu, May 8, 2014 at 4:55 PM, Dmitry Morozovsky <marck at rinet.ru> wrote:
> On Wed, 7 May 2014, Alan Somers wrote:
>
> [snip]
>
>> Even if nanosecond resolution isn't useful, monotonicity is.  Nobody
>> should be using a nonmonotonic clock just to measure durations.  I
>> started an audit of all of FreeBSD to look for other programs that use
>> gettimeofday to measure durations.  I haven't finished, but I've
>> already found a lot, including xz, ping, hastd, fetch, systat, powerd,
>> and others.  I don't have time to fix them, though.  Would you be
>> interested, or do you know anyone else who would?
>
> From your list, hastd seems to be the most dangerous point to me.
>
> Adding trociny@ as one of the most active hastd-related committers so the issue
> would not be lost in the areas...

In hastd's case, the problematic comparison is only used to print
debugging info.  It happens twice, in primary.c lines 1978 and 2039.

>
> --
> Sincerely,
> D.Marck                                     [DM5020, MCK-RIPE, DM3-RIPN]
> [ FreeBSD committer:                                 marck at FreeBSD.org ]
> ------------------------------------------------------------------------
> *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck at rinet.ru ***
> ------------------------------------------------------------------------