svn commit: r265367 - head/lib/libc/regex
theraven at FreeBSD.org
Mon May 5 18:55:55 UTC 2014
On 5 May 2014, at 18:42, Andrey Chernov <ache at freebsd.org> wrote:
> Please don't commit OpenBSD errors. Now you mix calloc() with the
> realloc() for the same variable later which makes calloc() zeroing
> pointless and waste of CPU.
The purpose of calloc() here is not (primarily) to get the zero'd size, it's to get the overflow-checking behaviour for calloc.
The uses of realloc() later do still potentially overflow, as they follow the realloc(pointer, size * sizeof(type)) antipattern.
More information about the svn-src-head