svn commit: r263922 - head/sys/netinet

[Michael Tuexen]

Author: tuexen
Date: Sat Mar 29 21:26:45 2014
New Revision: 263922
URL: http://svnweb.freebsd.org/changeset/base/263922

Log:
  Handle an edge case of address management similar to TCP.
  This needs to be reconsidered when the address handling
  will be reimplemented.
  The patch is from rrs at .
  
  MFC after: 3 days

Modified:
  head/sys/netinet/sctp_pcb.c

Modified: head/sys/netinet/sctp_pcb.c
==============================================================================
--- head/sys/netinet/sctp_pcb.c	Sat Mar 29 20:21:36 2014	(r263921)
+++ head/sys/netinet/sctp_pcb.c	Sat Mar 29 21:26:45 2014	(r263922)
@@ -772,7 +772,14 @@ sctp_del_addr_from_vrf(uint32_t vrf_id, 
 		}
 		SCTPDBG(SCTP_DEBUG_PCB4, "Deleting ifa %p\n", (void *)sctp_ifap);
 		sctp_ifap->localifa_flags &= SCTP_ADDR_VALID;
-		sctp_ifap->localifa_flags |= SCTP_BEING_DELETED;
+		/*
+		 * We don't set the flag. This means that the structure will
+		 * hang around in EP's that have bound specific to it until
+		 * they close. This gives us TCP like behavior if someone
+		 * removes an address (or for that matter adds it right
+		 * back).
+		 */
+		/* sctp_ifap->localifa_flags |= SCTP_BEING_DELETED; */
 		vrf->total_ifa_count--;
 		LIST_REMOVE(sctp_ifap, next_bucket);
 		sctp_remove_ifa_from_ifn(sctp_ifap);