svn commit: r263277 - head/sys/dev/nvme
Jim Harris
jimharris at FreeBSD.org
Mon Mar 17 22:36:05 UTC 2014
Author: jimharris
Date: Mon Mar 17 22:36:04 2014
New Revision: 263277
URL: http://svnweb.freebsd.org/changeset/base/263277
Log:
nvme: Remove the software progress marker SET_FEATURE command during
controller initialization.
The spec says OS drivers should send this command after controller
initialization completes successfully, but other NVMe OS drivers are
not sending this command. This change will therefore reduce differences
between the FreeBSD and other OS drivers.
Sponsored by: Intel
MFC after: 3 days
Modified:
head/sys/dev/nvme/nvme_ctrlr.c
Modified: head/sys/dev/nvme/nvme_ctrlr.c
==============================================================================
--- head/sys/dev/nvme/nvme_ctrlr.c Mon Mar 17 22:32:54 2014 (r263276)
+++ head/sys/dev/nvme/nvme_ctrlr.c Mon Mar 17 22:36:04 2014 (r263277)
@@ -842,16 +842,6 @@ nvme_ctrlr_start(void *ctrlr_arg)
for (i = 0; i < ctrlr->num_io_queues; i++)
nvme_io_qpair_enable(&ctrlr->ioq[i]);
-
- /*
- * Clear software progress marker to 0, to indicate to pre-boot
- * software that OS driver load was successful.
- *
- * Chatham does not support this feature.
- */
- if (pci_get_devid(ctrlr->dev) != CHATHAM_PCI_ID)
- nvme_ctrlr_cmd_set_feature(ctrlr,
- NVME_FEAT_SOFTWARE_PROGRESS_MARKER, 0, NULL, 0, NULL, NULL);
}
void
More information about the svn-src-head
mailing list