svn commit: r262727 - head/sys/net

[George Neville-Neil]

On Mar 4, 2014, at 12:14 , John Baldwin <jhb at FreeBSD.org> wrote:

> On Tuesday, March 04, 2014 12:09:47 am George V. Neville-Neil wrote:
>> Author: gnn
>> Date: Tue Mar  4 05:09:46 2014
>> New Revision: 262727
>> URL: http://svnweb.freebsd.org/changeset/base/262727
>> 
>> Log:
>>  Naming consistency fix. The routing code defines
>>  RADIX_NODE_HEAD_LOCK as grabbing the write lock,
>>  but RADIX_NODE_HEAD_LOCK_ASSERT as checking the read lock.
> 
> Actually, that isn't what RA_LOCKED means.  RA_LOCKED means that it is
> either read- or write-locked.  Note that you have now made 
> RADIX_NODE_HEAD_LOCK_ASSERT() a redundant copy of 
> RADIX_NODE_HEAD_WLOCK_ASSERT().  You should revert that part in some
> way (either remove HEAD_LOCK_ASSERT() entirely leaving just RLOCK_ASSERT() and 
> WLOCK_ASSERT(), or restore HEAD_LOCK_ASSERT() to using RA_LOCKED if there are 
> places that want to assert that the lock is held, but don't care if it is read 
> or write).

Actually I’ll revert the whole thing and to back to Vijay to rework this.

Best,
George