svn commit: r267758 - head

[Warner Losh]

On Jun 24, 2014, at 2:38 PM, Warner Losh <imp at bsdimp.com> wrote:

> 
> On Jun 24, 2014, at 2:26 PM, Warner Losh <imp at bsdimp.com> wrote:
> 
>> 
>> On Jun 24, 2014, at 10:25 AM, Andrey Chernov <ache at freebsd.org> wrote:
>> 
>>> On 24.06.2014 20:07, Warner Losh wrote:
>>>>> Log:
>>>>> Change suggestion how to set MAKESYSPATH as broken incremental build
>>>>> workaround. Magic ".../share/mk" (search directories up to /)
>>>>> does not work for f.e. /usr/src/gnu/lib/libgcc because the path
>>>>> inside is starting from /usr/obj hierarchy and ends up in
>>>>> /usr/share/mk, not in the /usr/src/share/mk where src.opts.mk is.
>>>>> IMHO proper fixing of incremental build is needed urgently.
>>>> 
>>>> I don’t understand how this is even possible. This change is wrong because it has a bogus path the doesn’t exist on all systems. I’m going to fix that.
>>> 
>>> How it is possible:
>>> cd /usr/src/gnu/lib/libgcc
>>> make
>> 
>> This does a recursive make, with pwd in /usr/obj….  That’s going to be utterly evil to fix…
> 
> Actually, adding a simple cd ${.CURDIR} before the make fixes this… We need to do it in 3 places.
> 
> # one could argue that we should just .include something to make unwind.h instead of this rube-goldberg reach over make…
> # and I’d agree with them…

This has been “fixed”…

that was a fun example…  I have to go from “fixed” to actually fixed now…

Warner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20140624/be376fd3/attachment.sig>