svn commit: r268461 - in head: . gnu/lib/libreadline gnu/lib/libreadline/history gnu/lib/libreadline/readline gnu/lib/libreadline/readline/doc gnu/usr.bin/gdb gnu/usr.bin/gdb/gdb gnu/usr.bin/gdb/gd...

[Adrian Chadd]

Sounds good. :)


-a


On 9 July 2014 16:25, Baptiste Daroussin <bapt at freebsd.org> wrote:
> On Wed, Jul 09, 2014 at 11:05:29AM -0700, Adrian Chadd wrote:
>> On 9 July 2014 10:23, Baptiste Daroussin <bapt at freebsd.org> wrote:
>> > On Wed, Jul 09, 2014 at 10:12:27AM -0700, Adrian Chadd wrote:
>> >> Hi,
>> >>
>> >> By doing this you're actually making more work for the really embedded
>> >> people who have size constraints on things.
>> >>
>> >> I dislike privatelib but it at least allows for code sharing where
>> >> before people would just statically link things into binaries.
>> >
>> > do you install gdb on your embedded environnement? because that is the only
>> > user of libreadline.
>>
>> See below.
>>
>> >>
>> >> I've had to actively undo this kind of dumb before in order to get
>> >> things to fit on very small flash root filesystems.
>> >>
>> >> Shared libraries are good. Please stop assuming we have lots of disk
>> >> space and RAM to have duplicates of things floating around.
>> >
>> > Facts:
>> > Before
>> > gdb + kgdb + gdbtui + libreadline.so.8 + libhistory.so.8 = 8976 k
>> > After
>> > gdb + kgdb + gdbtui = 8973 k
>> >
>> > I don't think I have damaged too much your embedded system am I wrong?
>> >
>> > Do I miss something?
>> >
>> > (Yes I have checked that before turning into an internallib given my first
>> > approach was to turn into a privatelib.
>>
>> Sure, except for the people who have done things like rolled local
>> configuration/management telnet interfaces for these things. They're
>> also using libreadline (and things like the cisco UI library.)
>>
>> And yeah, I do install gdb in there from time to time. Code sometimes
>> needs debugging. :-)
>>
> They can in that case use libedit which exports a libreadline compatibility
> interface in the base system (it is working well with the known cisco-like UI
> things ;) so even in that case I save them space given libedit is required for
> /bin/sh (the only known problem can happen if the are using unicode and from my
> last test the cisco UI thing is not unicode friendly either so that should make
> no difference here for them).
>
> The other thing is there are a couple of ABI incompatibilities between the
> libreadline version we have in base and newer libreadline which is getting more
> and more use making it more complicated to manage ports that requires newer
> readline.
>
> regards,
> Bapt