svn commit: r260898 - head/sys/kern

[Alexander Kabaev]

On Mon, 20 Jan 2014 11:32:29 -0500
John Baldwin <jhb at freebsd.org> wrote:

> On Sunday 19 January 2014 18:18:03 Rui Paulo wrote:
> > On 19 Jan 2014, at 17:59, Neel Natu <neel at FreeBSD.org> wrote:
> > > Author: neel
> > > Date: Mon Jan 20 01:59:35 2014
> > > New Revision: 260898
> > > URL: http://svnweb.freebsd.org/changeset/base/260898
> > > 
> > > Log:
> > >  Bump up WITNESS_COUNT from 1024 to 1536 so there are sufficient
> > > entries for
> > >  WITNESS to actually work.
> > 
> > This value should be automatically tuned...
> 
> How do you propose to do so?  This is the count of locks initialized
> before witness' own SYSINIT is executed and the array it sizes is
> allocated statically at compile time.  This used to not be a static
> array, but an intrusive list embedded in locks themselves, but we
> decided to shave a pointer off of each lock that was only used for
> that and to use a statically sized table instead.
> 
> -- 
> John Baldwin

As <CONSTANT1> + <CONSTANT2> * MAXCPU, as evidently most recent
overflows reported were caused by jacking MAXCPU up from its default
value? 

-- 
Alexander Kabaev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20140120/2113a3d9/attachment.sig>