svn commit: r260161 - in head/sys/arm: arm include

Zbigniew Bodek zbb at freebsd.org
Mon Jan 6 12:07:12 UTC 2014


2014/1/6 Andreas Tobler <andreast at freebsd.org>:
> On 06.01.14 03:55, Ian Lepore wrote:
>> On Wed, 2014-01-01 at 20:03 +0000, Zbigniew Bodek wrote:
>>> Author: zbb
>>> Date: Wed Jan  1 20:03:48 2014
>>> New Revision: 260161
>>> URL: http://svnweb.freebsd.org/changeset/base/260161
>>>
>>> Log:
>>>   Add polarity and level support to ARM GIC
>>>
>>>   Add suport for setting triggering level and polarity in GIC.
>>>   New function pointer was added to nexus which corresponds
>>>   to the function which sets level/sense in the hardware (GIC).
>>>
>>>   Submitted by:      Wojciech Macek <wma at semihalf.com>
>>>   Obtained from:     Semihalf
>>>
>>> Modified:
>>>   head/sys/arm/arm/gic.c
>>>   head/sys/arm/arm/intr.c
>>>   head/sys/arm/arm/nexus.c
>>>   head/sys/arm/include/intr.h
>>>
>> [...]
>>> Modified: head/sys/arm/include/intr.h
>>> ==============================================================================
>>> --- head/sys/arm/include/intr.h      Wed Jan  1 19:38:15 2014        (r260160)
>>> +++ head/sys/arm/include/intr.h      Wed Jan  1 20:03:48 2014        (r260161)
>>> @@ -68,6 +68,7 @@
>>>  #endif
>>>
>>>  #include <machine/psl.h>
>>> +#include <sys/bus.h>
>>>
>>>  int arm_get_next_irq(int);
>>>  void arm_mask_irq(uintptr_t);
>>> @@ -77,6 +78,8 @@ void arm_setup_irqhandler(const char *,
>>>      void *, int, int, void **);
>>>  int arm_remove_irqhandler(int, void *);
>>>  extern void (*arm_post_filter)(void *);
>>> +extern int (*arm_config_irq)(int irq, enum intr_trigger trig,
>>> +    enum intr_polarity pol);
>>>
>>>  void gic_init_secondary(void);
>>>
>>
>> It turns out that the new #include in this change is causing the current
>> arm tinderbox failures.  Enums can't have forward decls anymore, so the
>> fix for this may not be easy.
>
> I posted my try to fix this here:
>
> http://lists.freebsd.org/pipermail/freebsd-current/2014-January/047694.html
>
> Rebuilt 260333 successfully with it.
>
> Andreas
>

Hello.

Thank you very much. Can this be committed or are there any objections?

Best regards
zbb


More information about the svn-src-head mailing list