svn commit: r260233 - head/sys/kern

Mateusz Guzik mjg at FreeBSD.org
Fri Jan 3 16:36:56 UTC 2014


Author: mjg
Date: Fri Jan  3 16:36:55 2014
New Revision: 260233
URL: http://svnweb.freebsd.org/changeset/base/260233

Log:
  Plug a memory leak in dup2 when both old and new fd have ioctl caps.
  
  Reviewed by:	pjd
  MFC after:	3 days

Modified:
  head/sys/kern/kern_descrip.c

Modified: head/sys/kern/kern_descrip.c
==============================================================================
--- head/sys/kern/kern_descrip.c	Fri Jan  3 16:34:16 2014	(r260232)
+++ head/sys/kern/kern_descrip.c	Fri Jan  3 16:36:55 2014	(r260233)
@@ -878,6 +878,7 @@ do_dup(struct thread *td, int flags, int
 	/*
 	 * Duplicate the source descriptor.
 	 */
+	filecaps_free(&newfde->fde_caps);
 	*newfde = *oldfde;
 	filecaps_copy(&oldfde->fde_caps, &newfde->fde_caps);
 	if ((flags & DUP_CLOEXEC) != 0)


More information about the svn-src-head mailing list