svn commit: r262142 - head/sys/dev/usb/net

Craig Rodrigues rodrigc at FreeBSD.org
Tue Feb 18 01:20:27 UTC 2014


Author: rodrigc
Date: Tue Feb 18 01:20:26 2014
New Revision: 262142
URL: http://svnweb.freebsd.org/changeset/base/262142

Log:
  In ue_attach_post_task(), initialize curvnet to vnet0 before calling if_attach().
  Before this patch, curvnet was NULL.
  When the VIMAGE kernel option is enabled, this eliminates
  kernel panics when USB ethernet devices are plugged in.
  
  PR: 183835
  Submitted by: Hiroo Oono <hiroo.ono at gmail dot com>

Modified:
  head/sys/dev/usb/net/usb_ethernet.c

Modified: head/sys/dev/usb/net/usb_ethernet.c
==============================================================================
--- head/sys/dev/usb/net/usb_ethernet.c	Tue Feb 18 01:15:32 2014	(r262141)
+++ head/sys/dev/usb/net/usb_ethernet.c	Tue Feb 18 01:20:26 2014	(r262142)
@@ -208,6 +208,7 @@ ue_attach_post_task(struct usb_proc_msg 
 	sysctl_ctx_init(&ue->ue_sysctl_ctx);
 
 	error = 0;
+	CURVNET_SET_QUIET(vnet0);
 	ifp = if_alloc(IFT_ETHER);
 	if (ifp == NULL) {
 		device_printf(ue->ue_dev, "could not allocate ifnet\n");
@@ -254,6 +255,8 @@ ue_attach_post_task(struct usb_proc_msg 
 	if (ifp->if_capabilities & IFCAP_VLAN_MTU)
 		ifp->if_hdrlen = sizeof(struct ether_vlan_header);
 
+	CURVNET_RESTORE();
+
 	snprintf(num, sizeof(num), "%u", ue->ue_unit);
 	ue->ue_sysctl_oid = SYSCTL_ADD_NODE(&ue->ue_sysctl_ctx,
 	    &SYSCTL_NODE_CHILDREN(_net, ue),
@@ -267,6 +270,7 @@ ue_attach_post_task(struct usb_proc_msg 
 	return;
 
 fail:
+	CURVNET_RESTORE();
 	free_unr(ueunit, ue->ue_unit);
 	if (ue->ue_ifp != NULL) {
 		if_free(ue->ue_ifp);


More information about the svn-src-head mailing list