svn commit: r261283 - in head: contrib/libc++ contrib/libc++/include contrib/libc++/include/experimental contrib/libc++/include/ext contrib/libc++/src etc/mtree lib/libc++ sys/sys tools/build/mk

[Alan Somers]

On Thu, Jan 30, 2014 at 12:44 AM, Dimitry Andric <dim at freebsd.org> wrote:
> Author: dim
> Date: Thu Jan 30 07:44:22 2014
> New Revision: 261283
> URL: http://svnweb.freebsd.org/changeset/base/261283
>
> Log:
>   Import libc++ 3.4 release.  This contains a lot of bugfixes, and some
>   preliminary support for C++1y.
>
>   MFC after:    3 weeks
>
> Added:
...
>   head/contrib/libc++/include/locale

This broke the build when WITH_TESTS=yes is set.
contrib/atf/atf-c++/detail/application.cpp fails to compile as shown
below.  All that file does is #include several standard headers, so I
think the problem is strictly within libc++.  Tinderbox probably
didn't catch it because the base system includes so little C++, and
WITH_TESTS is off by default.  By inspection, I can't tell why locale
compiled before this change; the offending LOC are identical.  Can you
please take a look?

c++  -fpic -DPIC  -O2 -pipe -DHAVE_CONFIG_H -DATF_ARCH='"amd64"'
-DATF_BUILD_CC='"cc "' -DATF_BUILD_CFLAGS='"-O2 -pipe "'
-DATF_BUILD_CPP='"cpp "' -DATF_BUILD_CPPFLAGS='""'
-DATF_BUILD_CXX='"c++ "' -DATF_BUILD_CXXFLAGS='"-O2 -pipe"'
-DATF_CONFDIR='"/etc/atf"'
-DATF_C_TESTS_BASE='"/usr/tests/lib/atf/libatf-c"'
-DATF_INCLUDEDIR='"/usr/include"' -DATF_LIBDIR='"/usr/lib"'
-DATF_LIBEXECDIR='"/usr/libexec"' -DATF_MACHINE='"amd64"'
-DATF_M4='"/usr/bin/m4"' -DATF_PKGDATADIR='"/usr/share/atf"'
-DATF_SHELL='"/bin/sh"' -DATF_WORKDIR='"/tmp"'
-I/usr/home/alans/freebsd/head/contrib/atf
-I/usr/home/alans/freebsd/head/lib/atf/libatf-c++/../libatf-c -I.
-DHAVE_CONFIG_H -Qunused-arguments -fstack-protector -Wsystem-headers
-Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wpointer-arith
-Wno-uninitialized -Wno-empty-body -Wno-string-plus-int
-Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality
-Wno-unused-function -Wno-enum-conversion -Wno-c++11-extensions  -c
/usr/home/alans/freebsd/head/contrib/atf/atf-c++/detail/application.cpp
-o application.So
In file included from
/usr/home/alans/freebsd/head/contrib/atf/atf-c++/detail/application.cpp:42:
In file included from
/vmpool/obj/usr/home/alans/freebsd/head/tmp/usr/include/c++/v1/iostream:40:
In file included from
/vmpool/obj/usr/home/alans/freebsd/head/tmp/usr/include/c++/v1/istream:156:
In file included from
/vmpool/obj/usr/home/alans/freebsd/head/tmp/usr/include/c++/v1/ostream:133:
/vmpool/obj/usr/home/alans/freebsd/head/tmp/usr/include/c++/v1/locale:1015:27:
error: comparison of integers of different signs: 'long' and
'size_type' (aka 'unsigned long') [-Werror,-Wsign-compare]
        if (__a_end - __a == __buf.size())
            ~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~
/vmpool/obj/usr/home/alans/freebsd/head/tmp/usr/include/c++/v1/locale:1065:27:
error: comparison of integers of different signs: 'long' and
'size_type' (aka 'unsigned long') [-Werror,-Wsign-compare]
        if (__a_end - __a == __buf.size())
            ~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~
/vmpool/obj/usr/home/alans/freebsd/head/tmp/usr/include/c++/v1/locale:1119:27:
error: comparison of integers of different signs: 'long' and
'size_type' (aka 'unsigned long') [-Werror,-Wsign-compare]
        if (__a_end - __a == __buf.size())
            ~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~
3 errors generated.
*** [application.So] Error code 1

bmake[4]: stopped in /usr/home/alans/freebsd/head/lib/atf/libatf-c++
1 error


-Alan