svn commit: r261424 - head/sys/dev/mmc

John-Mark Gurney jmg at funkthat.com
Mon Feb 3 17:03:32 UTC 2014


Ian Lepore wrote this message on Mon, Feb 03, 2014 at 02:56 +0000:
> Author: ian
> Date: Mon Feb  3 02:56:23 2014
> New Revision: 261424
> URL: http://svnweb.freebsd.org/changeset/base/261424
> 
> Log:
>   Sort the list.
> 
> Modified:
>   head/sys/dev/mmc/mmc.c
> 
> Modified: head/sys/dev/mmc/mmc.c
> ==============================================================================
> --- head/sys/dev/mmc/mmc.c	Mon Feb  3 02:52:07 2014	(r261423)
> +++ head/sys/dev/mmc/mmc.c	Mon Feb  3 02:56:23 2014	(r261424)
> @@ -1756,10 +1756,11 @@ static driver_t mmc_driver = {
>  };
>  static devclass_t mmc_devclass;
>  
> -DRIVER_MODULE(mmc, ti_mmchs, mmc_driver, mmc_devclass, NULL, NULL);
>  DRIVER_MODULE(mmc, at91_mci, mmc_driver, mmc_devclass, NULL, NULL);
> -DRIVER_MODULE(mmc, sdhci_pci, mmc_driver, mmc_devclass, NULL, NULL);
>  DRIVER_MODULE(mmc, sdhci_bcm, mmc_driver, mmc_devclass, NULL, NULL);
>  DRIVER_MODULE(mmc, sdhci_fdt, mmc_driver, mmc_devclass, NULL, NULL);
> -DRIVER_MODULE(mmc, sdhci_ti, mmc_driver, mmc_devclass, NULL, NULL);
>  DRIVER_MODULE(mmc, sdhci_imx, mmc_driver, mmc_devclass, NULL, NULL);
> +DRIVER_MODULE(mmc, sdhci_pci, mmc_driver, mmc_devclass, NULL, NULL);
> +DRIVER_MODULE(mmc, sdhci_ti, mmc_driver, mmc_devclass, NULL, NULL);
> +DRIVER_MODULE(mmc, ti_mmchs, mmc_driver, mmc_devclass, NULL, NULL);
> +

Is there a reason we don't make mmc_driver/mmc_devclass global and put
all of these defines in their respective file instead of poluting an MI
file w/ MD info?

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."


More information about the svn-src-head mailing list