svn commit: r276187 - head/sys/arm/arm

John Baldwin jhb at freebsd.org
Wed Dec 31 19:09:31 UTC 2014


On Wednesday, December 24, 2014 9:05:47 pm Rui Paulo wrote:
> On Dec 24, 2014, at 17:31, Ian Lepore <ian at FreeBSD.org> wrote:
> > In every architecture and every place it's used, or just arm just here?
> 
> You're right, it can be found at least in MIPS and amd64.
> 
> > This appears to be an idiom, or at least something that has been pasted
> > in identical form in every arch so far.
> 
> The idiom is a bit different in amd64: the variable in the for-loop isn't 
immediately reused, but it's a global variable anyway...  That's what I 
thought deserves a comment.
> 
> Regarding the pmap_kenter_temporary(), the first problem is the function 
name: it might be a temporary mapping, but the real use is for crash dumps (I 
wonder why ACPI abuses this mapping).  The other problem is the fact that a 
pmap function is so tied to crash dumps.  However, that's a bigger problem.

ACPI abuses it because it is available (and we can't possibly generate a crash
dump early when ACPI uses it).  ACPI is only use it to map ACPI tables before
the VM system is initalized enough to map the tables using normal KVA.

-- 
John Baldwin


More information about the svn-src-head mailing list