svn commit: r275633 - in head: contrib/llvm/lib/Transforms/Vectorize sys/sys
Dimitry Andric
dim at FreeBSD.org
Tue Dec 9 07:34:30 UTC 2014
Author: dim
Date: Tue Dec 9 07:34:28 2014
New Revision: 275633
URL: https://svnweb.freebsd.org/changeset/base/275633
Log:
Pull in r223171 from upstream llvm trunk (by Michael Zolotukhin):
PR21302. Vectorize only bottom-tested loops.
rdar://problem/18886083
This fixes a bug in the llvm vectorizer, which could sometimes cause
vectorized loops to perform an additional iteration, leading to possible
buffer overruns. Symptoms of this, which are usually segfaults, were
first noticed when building gcc ports, here:
https://lists.freebsd.org/pipermail/freebsd-ports/2014-September/095466.html
https://lists.freebsd.org/pipermail/freebsd-toolchain/2014-September/001211.html
Since this fix is very important for ports, bump __FreeBSD_version to
make it easier for port maintainers to test whether the fix has been
applied.
Upstream PR: http://llvm.org/PR21302
MFC after: 3 days
Modified:
head/contrib/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
head/sys/sys/param.h
Modified: head/contrib/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
==============================================================================
--- head/contrib/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp Tue Dec 9 07:19:24 2014 (r275632)
+++ head/contrib/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp Tue Dec 9 07:34:28 2014 (r275633)
@@ -2864,6 +2864,14 @@ bool LoopVectorizationLegality::canVecto
if (!TheLoop->getExitingBlock())
return false;
+ // We only handle bottom-tested loops, i.e. loop in which the condition is
+ // checked at the end of each iteration. With that we can assume that all
+ // instructions in the loop are executed the same number of times.
+ if (TheLoop->getExitingBlock() != TheLoop->getLoopLatch()) {
+ DEBUG(dbgs() << "LV: loop control flow is not understood by vectorizer\n");
+ return false;
+ }
+
// We need to have a loop header.
DEBUG(dbgs() << "LV: Found a loop: " <<
TheLoop->getHeader()->getName() << '\n');
Modified: head/sys/sys/param.h
==============================================================================
--- head/sys/sys/param.h Tue Dec 9 07:19:24 2014 (r275632)
+++ head/sys/sys/param.h Tue Dec 9 07:34:28 2014 (r275633)
@@ -58,7 +58,7 @@
* in the range 5 to 9.
*/
#undef __FreeBSD_version
-#define __FreeBSD_version 1100048 /* Master, propagated to newvers */
+#define __FreeBSD_version 1100049 /* Master, propagated to newvers */
/*
* __FreeBSD_kernel__ indicates that this system uses the kernel of FreeBSD,
More information about the svn-src-head
mailing list