svn commit: r275473 - head/sys/netipsec

Andrey V. Elsukov ae at FreeBSD.org
Thu Dec 4 05:02:13 UTC 2014


Author: ae
Date: Thu Dec  4 05:02:12 2014
New Revision: 275473
URL: https://svnweb.freebsd.org/changeset/base/275473

Log:
  Fix style(9) and remove m_freem(NULL).
  Add XXX comment, it looks incorrect, because m_pkthdr.len is already
  incremented by M_PREPEND().
  
  Sponsored by:	Yandex LLC

Modified:
  head/sys/netipsec/keysock.c

Modified: head/sys/netipsec/keysock.c
==============================================================================
--- head/sys/netipsec/keysock.c	Thu Dec  4 01:21:56 2014	(r275472)
+++ head/sys/netipsec/keysock.c	Thu Dec  4 05:02:12 2014	(r275473)
@@ -145,12 +145,11 @@ key_sendup0(struct rawcb *rp, struct mbu
 		struct sadb_msg *pmsg;
 
 		M_PREPEND(m, sizeof(struct sadb_msg), M_NOWAIT);
-		if (!m) {
+		if (m == NULL) {
 			PFKEYSTAT_INC(in_nomem);
-			m_freem(m);
-			return ENOBUFS;
+			return (ENOBUFS);
 		}
-		m->m_pkthdr.len += sizeof(*pmsg);
+		m->m_pkthdr.len += sizeof(*pmsg); /* XXX: is this correct? */
 
 		pmsg = mtod(m, struct sadb_msg *);
 		bzero(pmsg, sizeof(*pmsg));


More information about the svn-src-head mailing list