svn commit: r275136 - in head/sys: dev/e1000 dev/ixgbe kern sys

[Jack Vogel]

Really, and did I say that I approved, because I do not recall the event?

Jack


On Mon, Dec 1, 2014 at 8:08 AM, Alfred Perlstein <bright at mu.org> wrote:

> Jack you were asked.   Please see the review system.
>
> Sent from my iPhone
>
> On Dec 1, 2014, at 8:05 AM, Jack Vogel <jfvogel at gmail.com> wrote:
>
> There is no mystery about who's drivers these are, and its not like it
> would
> take a lot of effort to figure out ownership and ask us for review.
>
> Remove this commit until I have had time to look it over!
>
> Jack
>
>
> On Mon, Dec 1, 2014 at 7:56 AM, Alfred Perlstein <bright at mu.org> wrote:
>
>>
>>
>> > On Dec 1, 2014, at 7:49 AM, Hans Petter Selasky <hps at selasky.org>
>> wrote:
>> >
>> >> On 12/01/14 16:45, Alfred Perlstein wrote:
>> >>
>> >> > Hi,
>> >>>
>> >>> It is quite early, actually:
>> >>>
>> >>> SYSINIT(sysctl, SI_SUB_KMEM, SI_ORDER_FIRST, sysctl_register_all, 0);
>> >>>
>> >>> In some parts of the machine independent, MI, code you neee to keep
>> the TUNABLE_FETCH'es, because its run before SI_SUB_KMEM !
>> >>
>> >> Then it will not work unless I move the global n_queues sysctl
>> creation into the driver's mod load function.
>> >>
>> >> Is that ok?
>> >
>> > Are you asking me?
>>
>> In soviet russia no one is ever sure whom to ask for permission to
>> proceed.
>>
>> (Also you have significant commits to the driver so it makes sense. )
>>
>>
>> >
>> > --HPS
>> >
>> >
>>
>>
>