svn commit: r267937 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/aggs cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/json cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/...

[Warner Losh]

On Aug 3, 2014, at 9:47 AM, Warner Losh <imp at bsdimp.com> wrote:

> 
> On Jul 28, 2014, at 9:23 PM, John Baldwin <jhb at FreeBSD.org> wrote:
> 
>> On Thursday 26 June 2014 21:45:49 Rui Paulo wrote:
>>> Author: rpaulo
>>> Date: Thu Jun 26 21:45:49 2014
>>> New Revision: 267937
>>> URL: http://svnweb.freebsd.org/changeset/base/267937
>>> 
>>> Log:
>>> MFV illumos
>>> 
>>> 4477 DTrace should speak JSON
>>> 
>>> MFC after:	2 weeks
>> 
>> This makes kernel builds depend on userland sources.  This breaks a lot of my 
>> work trees where I only checkout 'sys', and breaks a generally long-standing 
>> feature that the kernel was self-contained (recent bmake breakage to require 
>> the '-m /usr/src/share/mk' hack aside).  Perhaps you could copy strtolctype.h
>> to sys/cddl/contrib/opensolaris/common/util?  We already duplicate 
>> sys/cddl/contrib/opensolaris/common/avl/avl.c in a like manner, presumably for 
>> the same reason.
> 
> Just FYI: my intention is to remove that hack requirement, at least for host != kernel
> version cases.. I’ve had some issues with the “fix” that wound up with a different
> set of hacks once the initial MAKESYSPATH is fixed.

Ah, the modules issue…  I didn’t understand the breakage until I tried it myself...

https://phabric.freebsd.org/D529

will fix it, if anybody wants to comment on it.

Warner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20140803/8f41db24/attachment.sig>