svn commit: r255573 - head/sys/dev/drm2/radeon

John Baldwin jhb at freebsd.org
Mon Sep 16 19:37:49 UTC 2013


On Saturday, September 14, 2013 1:24:42 pm Jean-Sebastien Pedron wrote:
> Author: dumbbell
> Date: Sat Sep 14 17:24:41 2013
> New Revision: 255573
> URL: http://svnweb.freebsd.org/changeset/base/255573
> 
> Log:
>   drm/radeon: Fix usage of pci_save_state() and pci_restore_state()
>   
>   Calling those functions with the drmn device as argument causes a panic,
>   because it's not a direct child of pci$N. They must be called with the
>   vgapci device instead.
>   
>   This fix is not enough to make suspend/resume work reliably.
>   
>   Approved by:	re (blanket)

Note that the PCI bus layer already does pci_save_state() during suspend
and pci_restore_state() during resume, so it is redundant for a driver to
do so.

-- 
John Baldwin


More information about the svn-src-head mailing list