svn commit: r255457 - head/usr.sbin/pkg

Andrew Turner andrew at fubar.geek.nz
Thu Sep 12 19:29:14 UTC 2013


On Tue, 10 Sep 2013 22:29:38 -0500
Nathan Whitehorn <nwhitehorn at freebsd.org> wrote:

> On 09/10/13 15:56, Baptiste Daroussin wrote:
> > Author: bapt
> > Date: Tue Sep 10 20:56:01 2013
> > New Revision: 255457
> > URL: http://svnweb.freebsd.org/changeset/base/255457
> >
> > Log:
> >    Add support to detect arm vs armv6
> >    
> >    There are two different versions of the ARM ABI depending on the
> >    TARGET_ARCH. As these are sligntly different a package built for
> >    one may not work on another. We need to detect which one we are
> > on by parsing the .ARM.attributes section.
> >    
> >    This will only work on the ARM EABI as this section is part of
> > the ABI definition. As armv6 only supports the ARM EABI this is not
> > a problem for the oabi.
> >    
> >    Older versions of libelf in FreeBSD fail to read the
> >    .ARM.attributes section needed. As armv6 is unsupported on these
> >    versions we can assume we are running on arm.
> >    
> 
> Picking a random commit: I don't suppose we can just use MACHINE_ARCH 
> for these identifiers? It encapsulates everything needed for
> compatibility. -Nathan
> 
> 

I have the attached patch to add a MACHINE_ARCH elf note. It would
remove the need to parse the .ARM.attributes section. NetBSD is doing
something similar to the patch where it appears they have
a .note.netbsd.march section.

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: machine_arch_note.diff
Type: text/x-patch
Size: 960 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20130912/9ef195ec/attachment.bin>


More information about the svn-src-head mailing list