svn commit: r256779 - head/sys/powerpc/pseries

[Nathan Whitehorn]

Author: nwhitehorn
Date: Sun Oct 20 01:40:59 2013
New Revision: 256779
URL: http://svnweb.freebsd.org/changeset/base/256779

Log:
  Clean up some debug code that snuck in. Add a block comment on future work.

Modified:
  head/sys/powerpc/pseries/phyp_llan.c

Modified: head/sys/powerpc/pseries/phyp_llan.c
==============================================================================
--- head/sys/powerpc/pseries/phyp_llan.c	Sun Oct 20 01:31:09 2013	(r256778)
+++ head/sys/powerpc/pseries/phyp_llan.c	Sun Oct 20 01:40:59 2013	(r256779)
@@ -381,15 +381,14 @@ llan_send_packet(void *xsc, bus_dma_segm
 		bufdescs[i] |= segs[i].ds_addr;
 	}
 
-	error = phyp_hcall(H_SEND_LOGICAL_LAN, sc->unit, bufdescs[0],
+	phyp_hcall(H_SEND_LOGICAL_LAN, sc->unit, bufdescs[0],
 	    bufdescs[1], bufdescs[2], bufdescs[3], bufdescs[4], bufdescs[5], 0);
-#if 0
-	if (error)
-		sc->ifp->if_drv_flags |= IFF_DRV_OACTIVE;
-
-	/* XXX: handle H_BUSY? */
-	/* H_SEND_LOGICAL_LAN returning 0 implies completion of the send op */
-#endif
+	/*
+	 * The hypercall returning implies completion -- or that the call will
+	 * not complete. In principle, we should try a few times if we get back
+	 * H_BUSY based on the continuation token in R4. For now, just drop
+	 * the packet in such cases.
+	 */
 }
 
 static void
@@ -425,9 +424,9 @@ llan_start_locked(struct ifnet *ifp)
 			}
 		}
 
-		bus_dmamap_load_mbuf(sc->tx_dma_tag, sc->tx_dma_map, //xfer->dmamap,
+		bus_dmamap_load_mbuf(sc->tx_dma_tag, sc->tx_dma_map,
 			mb_head, llan_send_packet, sc, 0);
-		bus_dmamap_unload(sc->tx_dma_tag, sc->tx_dma_map); // XXX
+		bus_dmamap_unload(sc->tx_dma_tag, sc->tx_dma_map);
 		m_freem(mb_head);
 	}
 }