svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts

[Nathan Whitehorn]

On 10/11/13 22:41, Devin Teske wrote:
> Author: dteske
> Date: Fri Oct 11 20:41:35 2013
> New Revision: 256343
> URL: http://svnweb.freebsd.org/changeset/base/256343
>
> Log:
>   Add zfsboot module as an option for automatic configuration. Default is
>   to run interactively but it can be scripted too (optinally completely
>   non-interactive). Currently supports GELI and all ZFS vdev types. Also
>   performs validation on selections/settings providing error messages if
>   necessary, explaining (in plain language) what the issue is. Currently
>   the auto partitioning of naked disks only supports GPT and MBR (VTOC8
>   pending for sparc64), so is only available for i386/amd64 install.
>   
>   Submitted by:	Allan Jude <freebsd at allanjude.com>, myself
>   Reviewed by:	Allan Jude <freebsd at allanjude.com>
>   Approved by:	re (glebius)

Hi Devin --

As was discussed on the mailing list, this patch still has some issues
that need to be resolved, for example the use of camcontrol
unconditionally even when the disks may not be CAM and destruction of
existing sub-partitioning for MBR disks. There were some others brought
up in the discussion as well. I am surprised you committed it,
especially to stable/10, before those issues were resolved. I'm also not
sure if people can review their own patches.

Installer regressions are very easy to introduce and very problematic
when created. Real review for installer changes is thus especially
important this late in the release cycle. Do you have any plans to fix
these issues in the very near future?
-Nathan