svn commit: r256151 - in head/sys/dev: nvd nvme

[Glen Barber]

On Tue, Oct 08, 2013 at 03:44:04PM +0000, Jim Harris wrote:
> Author: jimharris
> Date: Tue Oct  8 15:44:04 2013
> New Revision: 256151
> URL: http://svnweb.freebsd.org/changeset/base/256151
> 
> Log:
>   Add driver-assisted striping for upcoming Intel NVMe controllers that can
>   benefit from it.
>   

> Modified: head/sys/dev/nvme/nvme_ns.c
> ==============================================================================
> --- head/sys/dev/nvme/nvme_ns.c	Tue Oct  8 14:10:32 2013	(r256150)
> +++ head/sys/dev/nvme/nvme_ns.c	Tue Oct  8 15:44:04 2013	(r256151)
> @@ -34,13 +34,31 @@ __FBSDID("$FreeBSD$");
>  #include <sys/disk.h>
>  #include <sys/fcntl.h>
>  #include <sys/ioccom.h>
> +#include <sys/malloc.h>
>  #include <sys/module.h>
>  #include <sys/proc.h>
>  
>  #include <dev/pci/pcivar.h>
>  
> +#include <geom/geom.h>
> +
>  #include "nvme_private.h"
>  

I think an include is missing.  This breaks the LINT build.

cc  -c -O2 -pipe -fno-strict-aliasing  -std=c99  -Wall -Wredundant-decls
-Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes
-Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign
-fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-option
-Wno-error-tautological-compare -Wno-error-empty-body
-Wno-error-parentheses-equality  -nostdinc  -I. -I/src/sys
-I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL
-DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -DGPROF -DGPROF4
-DGUPROF -fno-builtin -fno-omit-frame-pointer
-mno-omit-leaf-frame-pointer -mno-aes -mno-avx -mcmodel=kernel
-mno-red-zone -mno-mmx -mno-sse -msoft-float
-fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -Werror
-pg /src/sys/dev/nvme/nvme_ns.c
In file included from /src/sys/dev/nvme/nvme_ns.c:43:
/src/sys/geom/geom.h:356:3: error: implicit declaration of function
'KASSERT' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                KASSERT(g_valid_obj(ptr) == 0,
                ^
/src/sys/geom/geom.h:357:8: error: expression result unused
[-Werror,-Wunused-value]
                    ("g_free(%p) of live object, type %d", ptr,
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/src/sys/geom/geom.h:357:46: error: expression result unused
[-Werror,-Wunused-value]
                    ("g_free(%p) of live object, type %d", ptr,
                                                           ^~~
3 errors generated.
*** Error code 1

http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-amd64-amd64.full

Glen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20131008/4ff6b8c1/attachment.sig>