svn commit: r258739 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

Andriy Gapon avg at FreeBSD.org
Fri Nov 29 12:19:52 UTC 2013


Author: avg
Date: Fri Nov 29 12:19:52 2013
New Revision: 258739
URL: http://svnweb.freebsd.org/changeset/base/258739

Log:
  zfs mappedread_sf: assert that a page is never partially valid
  
  ZFS never partially validates or invalidates a page.
  The higher level VM should not do that either.
  mappedread_sf correct operation depends on a page being either fully
  valid or invalid.
  
  MFC after:	7 days

Modified:
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c

Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
==============================================================================
--- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c	Fri Nov 29 08:22:48 2013	(r258738)
+++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c	Fri Nov 29 12:19:52 2013	(r258739)
@@ -587,8 +587,10 @@ mappedread_sf(vnode_t *vp, int nbytes, u
 				vm_page_activate(pp);
 			}
 			vm_page_unlock(pp);
-		} else
+		} else {
+			ASSERT3U(pp->valid, ==, VM_PAGE_BITS_ALL);
 			vm_page_sunbusy(pp);
+		}
 		if (error)
 			break;
 		uio->uio_resid -= bytes;


More information about the svn-src-head mailing list