svn commit: r258545 - head/sys/dev/usb/controller

Hans Petter Selasky hselasky at FreeBSD.org
Mon Nov 25 10:58:03 UTC 2013


Author: hselasky
Date: Mon Nov 25 10:58:02 2013
New Revision: 258545
URL: http://svnweb.freebsd.org/changeset/base/258545

Log:
  Comply to the XHCI specification. Certain input context fields should
  always be zero.
  
  MFC after:	1 week

Modified:
  head/sys/dev/usb/controller/xhci.c

Modified: head/sys/dev/usb/controller/xhci.c
==============================================================================
--- head/sys/dev/usb/controller/xhci.c	Mon Nov 25 10:49:17 2013	(r258544)
+++ head/sys/dev/usb/controller/xhci.c	Mon Nov 25 10:58:02 2013	(r258545)
@@ -2540,7 +2540,11 @@ xhci_configure_device(struct usb_device 
 
 	xhci_ctx_set_le32(sc, &pinp->ctx_slot.dwSctx2, temp);
 
-	temp = XHCI_SCTX_3_DEV_ADDR_SET(udev->address) |
+	/*
+	 * These fields should be initialized to zero, according to
+	 * XHCI section 6.2.2 - slot context:
+	 */
+	temp = XHCI_SCTX_3_DEV_ADDR_SET(0) |
 	    XHCI_SCTX_3_SLOT_STATE_SET(0);
 
 	xhci_ctx_set_le32(sc, &pinp->ctx_slot.dwSctx3, temp);


More information about the svn-src-head mailing list