svn commit: r258139 - head/contrib/gperf/src

Jung-uk Kim jkim at FreeBSD.org
Thu Nov 14 19:10:14 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-11-14 13:41:58 -0500, Sean Bruno wrote:
> Author: sbruno Date: Thu Nov 14 18:41:58 2013 New Revision: 258139 
> URL: http://svnweb.freebsd.org/changeset/base/258139
> 
> Log: Repair build after svn r258115
> 
> options.get_size_type() appears to return a const char *, so assume
> that its a string as oppose to *nothing*.  I have no idea what
> apple's code is trying to do here:
> 
> http://opensource.apple.com/source/gperf/gperf-9/patches/size_type.patch

It
> 
looks like the code is in fact unreachable, i.e., the language
option must be KRC, C, ANSIC, or CPLUSPLUS.  Therefore, the last test,
"option[ANSIC] | option[CPLUSPLUS]" is actually redundant.

I believe your correction is sufficient for now.

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQEcBAEBAgAGBQJShR8wAAoJEHyflib82/FGTlMH/3c6WrX6VPWJ1Xu9sF1wcT8n
S9VZG8RTY4KLc75oIAsvgc+970h7EWOhqNyNpI0JmayeW7OrG6Fqq7uT6EqtAU3i
iiYUXIW1tg5066G2VnnJW34z38Jv2V8DkjD7iF9ZdXnCMxS3tUdQiQMFCr2FKrJd
cT5+7z2+XvRq3QCT36hrSK65l3XDuUr08AVXxE9dJsReQoZMit9iHIctoJmGTqng
TaAuBiyKU7BG6Hr4hSbAni9XvzG7NRDOSU5Njc0QffRS3ZnyQZlEUAmD1f6uPUd6
ftPFIMZEk0hdCncWhKtT5HCxUyaw6RQPHF7ZRz3EmuDrxDu26qKIGAcmhizbwVg=
=tFjA
-----END PGP SIGNATURE-----


More information about the svn-src-head mailing list