svn commit: r252481 - in head: etc sbin/devd
Andriy Gapon
avg at FreeBSD.org
Thu Nov 7 12:12:09 UTC 2013
First, apologies for this very delayed reaction.
on 02/07/2013 00:20 Alan Somers said the following:
> Author: asomers
> Date: Mon Jul 1 21:20:17 2013
> New Revision: 252481
> URL: http://svnweb.freebsd.org/changeset/base/252481
>
> Log:
> Add syslog(3) support to devd(8).
>
[snip]
> @@ -243,8 +244,7 @@ bool
> action::do_action(config &c)
> {
> string s = c.expand_string(_cmd.c_str());
> - if (Dflag)
> - fprintf(stderr, "Executing '%s'\n", s.c_str());
> + devdlog(LOG_NOTICE, "Executing '%s'\n", s.c_str());
My opinion that this message does not deserve LOG_NOTICE message.
LOG_NOTICE Conditions that are not error conditions, but should possi‐
bly be handled specially.
I don't think that devd reacting to an event deserves any special handling from
an administrator. All LOG_NOTICE messages are logged into /var/log/messages by
default.
Besides, many actions already explicitly call logger(1) and sometimes that's the
only thing that they do.
So on a system with default syslog configuration one can see messages like:
devd: Executing 'logger Unknown USB device: vendor 0x03f0 product 0x102a bus uhub7'
root: Unknown USB device: vendor 0x03f0 product 0x102a bus uhub7
I think that LOG_INFO should be fine for these messages.
> my_system(s.c_str());
> return (true);
> }
> @@ -1078,10 +1090,27 @@ gensighand(int)
> romeo_must_die = 1;
> }
>
> +/*
> + * Local logging function. Prints to syslog if we're daemonized; syslog
> + * otherwise.
> + */
Minor nit: there is a typo in this comment.
> +static void
> +devdlog(int priority, const char* fmt, ...)
> +{
> + va_list argp;
> +
> + va_start(argp, fmt);
> + if (dflag)
> + vfprintf(stderr, fmt, argp);
> + else
> + vsyslog(priority, fmt, argp);
> + va_end(argp);
> +}
> +
--
Andriy Gapon
More information about the svn-src-head
mailing list