svn commit: r257696 - in head: libexec/rbootd share/man/man9 sys/compat/svr4 sys/net sys/sys

[John Baldwin]

On Tuesday, November 05, 2013 2:29:04 pm Gleb Smirnoff wrote:
> On Tue, Nov 05, 2013 at 11:56:09AM -0500, John Baldwin wrote:
> J> On Tuesday, November 05, 2013 5:29:48 am Gleb Smirnoff wrote:
> J> > Author: glebius
> J> > Date: Tue Nov  5 10:29:47 2013
> J> > New Revision: 257696
> J> > URL: http://svnweb.freebsd.org/changeset/base/257696
> J> > 
> J> > Log:
> J> >   Drop support for historic ioctls and also undefine them, so that code
> J> >   that checks their presence via ifdef, won't use them.
> J> 
> J> Most of these are COMPAT_43, but one appears to be a 9.x ioctl?  If that's the
> J> case it's implementation should probably stick around under appropriate
> J> COMPAT_FREEBSD<x> macros.  It looks like it goes all the way back to 4.4BSD,
> J> so at least COMPAT_FREEBSD4 and later should define the implementation to
> J> preserve ABI compat for old binaries.
> 
> Why should we support such broken configurations as running new kernel and
> ancient core base system utilities? The efforts to keep this are much more
> expensive, then yields.

Is this ioctl only ever used by ifconfig and not suitable for public consumption?
If so, then I think removing it is fine.  However, it's not clear that this is
the case from the commit, and it's good to make sure it is really the case.

It might be nice to hide ioctls we think are internal under some #ifdef that tools
like ifconfig #define to expose them so we are more explicit about which ioctls
are purely internal, etc.

-- 
John Baldwin