svn commit: r250430 - head/sbin/dmesg

Eitan Adler eadler at freebsd.org
Fri May 10 12:44:08 UTC 2013


On 10 May 2013 03:42, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> On Fri, May 10, 2013 at 03:42:48AM +0000, Eitan Adler wrote:
>> New Revision: 250430
>> URL: http://svnweb.freebsd.org/changeset/base/250430
>>
>> @@ -79,15 +80,20 @@ main(int argc, char *argv[])
>>       kvm_t *kd;
>>       size_t buflen, bufpos;
>>       long pri;
>> -     int all, ch;
>> +     int ch, clear;
>> +     bool all;
>>
>> -     all = 0;
>> +     all = false;
>> +     clear = false;
>>       (void) setlocale(LC_CTYPE, "");
>
> It's a bit weird that you've left the cast here...

I didn't modify this line

>
> ... and here (also: notice inconsistent spacing),

Or this one.

>>  void
>>  usage(void)
>>  {
>> -     (void)fprintf(stderr, "usage: dmesg [-a] [-M core [-N system]]\n");
>> +     fprintf(stderr, "usage: dmesg [-ac] [-M core [-N system]]\n");
>
> but removed it here for no particular reason.

Notice the additional 'c' in usage().

-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams


More information about the svn-src-head mailing list