svn commit: r252376 - head/lib/libutil

[Dimitry Andric]

On Jun 29, 2013, at 18:19, Konstantin Belousov <kostikbel at gmail.com> wrote:
> On Sat, Jun 29, 2013 at 03:52:49PM +0000, Tim Kientzle wrote:
>> Author: kientzle
>> Date: Sat Jun 29 15:52:48 2013
>> New Revision: 252376
>> URL: http://svnweb.freebsd.org/changeset/base/252376
>> 
>> Log:
>>  Fix -Wunsequenced warning
> What is this ? From the name of the warning, it sounds as if the problem
> is in the lack of sequence point between two modifications of the same
> variable in the expression ?
> 
> But, there function' argument evaluation and function call are separated
> by seq point, AFAIR.  Could you, please, clarify ?

Yes, a function call is a sequence point.  The -Wunsequenced warning
was made too aggressive in this trunk upstream commit:
<http://llvm.org/viewvc/llvm-project?rev=185035&view=rev>

I pointed out the problem to the author, and he fixed it in:
<http://llvm.org/viewvc/llvm-project?rev=185282&view=rev>

-Dimitry