svn commit: r251562 - head/sys/fs/ext2fs

Pedro F. Giffuni pfg at FreeBSD.org
Sun Jun 9 01:38:52 UTC 2013


Author: pfg
Date: Sun Jun  9 01:38:51 2013
New Revision: 251562
URL: http://svnweb.freebsd.org/changeset/base/251562

Log:
  e2fs_bpg and e2fs_isize are always unsigned.
  
  The superblock in ext2fs defines all the fields as unsigned but for
  some reason the in-memory superblock was carrying e2fs_bpg and
  e2fs_isize as signed.
  
  We should preserve the specified types for consistency.
  
  MFC after:	5 days

Modified:
  head/sys/fs/ext2fs/ext2fs.h

Modified: head/sys/fs/ext2fs/ext2fs.h
==============================================================================
--- head/sys/fs/ext2fs/ext2fs.h	Sun Jun  9 01:19:22 2013	(r251561)
+++ head/sys/fs/ext2fs/ext2fs.h	Sun Jun  9 01:38:51 2013	(r251562)
@@ -153,7 +153,7 @@ struct m_ext2fs {
 	char     e2fs_fmod;       /* super block modified flag */
 	uint32_t e2fs_bsize;      /* Block size */
 	uint32_t e2fs_bshift;     /* calc of logical block no */
-	int32_t  e2fs_bpg;	  /* Number of blocks per group */
+	uint32_t e2fs_bpg;	  /* Number of blocks per group */
 	int64_t  e2fs_qbmask;     /* = s_blocksize -1 */
 	uint32_t e2fs_fsbtodb;    /* Shift to get disk block */
 	uint32_t e2fs_ipg;	  /* Number of inodes per group */
@@ -164,7 +164,7 @@ struct m_ext2fs {
 	uint32_t e2fs_fpg;	  /* Number of fragments per group */
 	uint32_t e2fs_gdbcount;   /* Number of group descriptors */
 	uint32_t e2fs_gcount;     /* Number of groups */
-	int32_t  e2fs_isize;      /* Size of inode */
+	uint32_t e2fs_isize;	  /* Size of inode */
 	uint32_t e2fs_total_dir;  /* Total number of directories */
 	uint8_t	*e2fs_contigdirs; /* (u) # of contig. allocated dirs */
 	char     e2fs_wasvalid;   /* valid at mount time */


More information about the svn-src-head mailing list