svn commit: r250991 - in head: contrib/jemalloc/include/jemalloc include lib/libc/stdlib/jemalloc

[Dimitry Andric]

On 2013-05-25 20:59, Marcel Moolenaar wrote:
> Author: marcel
> Date: Sat May 25 18:59:11 2013
> New Revision: 250991
> URL: http://svnweb.freebsd.org/changeset/base/250991
>
> Log:
>    Make the malloc(3) family of functions weak and make their non-weak
>    implementations visible for use by applications. The functions $F that
>    are now weak symbols are:
>    	allocm, calloc, dallocm, free, malloc, malloc_usable_size,
>    	nallocm, posix_memalign, rallocm, realloc, sallocm
>
>    The non-weak implementations of $F are exported as __$F.

Hi Marcel,

This commit seems to lead to various problems in ports, and possibly
other software.  For example, with Firefox I now always get a few
messages like:

   firefox in free(): warning: malloc() has never been called

Another example is the devel/talloc port, which now dies with:

   [...]
   Checking linker accepts ['-undefined', 'dynamic_lookup']                                        : yes
   'configure' finished successfully (2m33.364s)
   <jemalloc>: /share/dim/src/freebsd/head/lib/libc/../../contrib/jemalloc/include/jemalloc/internal/arena.h:1002: Failed assertion: "((uintptr_t)ptr & PAGE_MASK) == 0"
   Abort trap (core dumped)
   ===>  Script "buildtools/bin/waf configure" failed unexpectedly.

See also the post here:
<http://lists.freebsd.org/pipermail/freebsd-current/2013-June/042220.html>

Can we please revert this commit for now, if a fix for these problems is
not readily available?

-Dimitry