svn commit: r253786 - in head/sys: dev/random modules/padlock_rng modules/rdrand_rng modules/yarrow_rng
des at des.no
Wed Jul 31 09:33:48 UTC 2013
"David O'Brien" <obrien at FreeBSD.org> writes:
> Dag-Erling Smørgrav <des at des.no> writes:
> > We've had a policy for several years now that all changes to the
> > PRNG code in the kernel and libc must be reviewed by so at .
> Where was this policy published or communicated?
> There is no MAINTAINER line in sys/dev/random/, nor an entry in
> /usr/src/MAINTAINERS. It is hard to follow some policy that cannot
> be found.
If it isn't adequately documented, then we need to look into that. It's
not the only such case - jfv@'s hard lock on Intel NIC drivers isn't
documented either. That doesn't mean we shouldn't enforce it.
> This change does not change any of the PRNG algorithms.
You know as well as I do that "I didn't change anything" is in the top
five on the list of "programmers' famous last words".
> Do you have any specific concerns?
I don't have any major issues with the patch, but it should still have
been submitted for pre-commit review.
I have two minor issues:
- The sysctl is currently a space-separated list with an extraneous
leading space and a magic string (which contains separators) to
indicate an empty list. At the very least, the leading space should
be removed and the magic string should be changed to not include
spaces; "none" should suffice. I would prefer a comma-separated list
and an empty string to indicate an empty list.
- The non-standard (at least in an IT context) spelling of "adapter".
I'll try to get a second opinion within the day.
Dag-Erling Smørgrav - des at des.no
More information about the svn-src-head