svn commit: r253708 - head/sys/dev/ipmi
jhb at freebsd.org
Mon Jul 29 19:14:37 UTC 2013
On Saturday, July 27, 2013 12:32:34 pm Sean Bruno wrote:
> Author: sbruno
> Date: Sat Jul 27 16:32:34 2013
> New Revision: 253708
> URL: http://svnweb.freebsd.org/changeset/base/253708
> At some point after stable/7 the ACPI and ISA interfaces to the IPMI controller
> no longer have the parent in the device tree. This causes the identify
> function in ipmi_isa.c to attempt to probe and poke at the ISA IPMI interface
They never had a common parent, even in 6.x and 7.x.
> Move the check for ipmi_attached out of the ipmi_isa_attach function and into
> the ipmi_isa_identify function. Remove the check of the device tree for
> ipmi devices attached.
> This probing appears to make Broadcom management firmware on Dell machines
> crash and emit NMI EISA warnings at various times requiring power cycles
> of the machines to restore.
This makes no sense. All you are doing is skipping ipmi_smbios_identify()
which just looks at the SMBIOS table in RAM. It doesn't try to probe the
BMC at all (no register accesses, etc.). If just reading a table in memory
causes side effects, then running dmidecode in userland should be hosing your
machines as well.
More information about the svn-src-head