svn commit: r253618 - head/sys/dev/usb/gadget

John Baldwin jhb at
Thu Jul 25 16:04:38 UTC 2013

On Wednesday, July 24, 2013 2:32:15 pm David E. O'Brien wrote:
> Author: obrien
> Date: Wed Jul 24 18:32:15 2013
> New Revision: 253618
> URL:
> Log:
>   per style(9):
>      Kernel include files (i.e. sys/*.h) come first; normally, include
>      <sys/types.h> OR <sys/param.h>, but not both.  <sys/types.h> includes
>      <sys/cdefs.h>, and it is okay to depend on that.

This is not fully correct.  The consistent style throughout the tree when
using _FBSDID() is:

#include <sys/cdefs.h>

#include <sys/param.h>

Please fix these to match that.  It might not be a bad idea to document the
__FBSDID() practice in style.9 while you are at it.

John Baldwin

More information about the svn-src-head mailing list