svn commit: r253554 - head/sys/vm

Jeremie Le Hen jlh at
Mon Jul 22 21:47:15 UTC 2013

Author: jlh
Date: Mon Jul 22 21:47:14 2013
New Revision: 253554

  Fix a panic in the racct code when munlock(2) is called with incorrect values.
  The racct code in sys_munlock() assumed that the boundaries provided by the
  userland were correct as long as vm_map_unwire() returned successfully.
  However the latter contains its own logic and sometimes manages to do something
  out of those boundaries, even if they are buggy.  This change makes the racct
  code to use the accounting done by the vm layer, as it is done in other places
  such as vm_mlock().
  Despite fixing the panic, Alan Cox pointed that this code is still race-y
  though: two simultaneous callers will produce incorrect values.
  Reviewed by:	alc
  MFC after:	7 days


Modified: head/sys/vm/vm_mmap.c
--- head/sys/vm/vm_mmap.c	Mon Jul 22 19:38:21 2013	(r253553)
+++ head/sys/vm/vm_mmap.c	Mon Jul 22 21:47:14 2013	(r253554)
@@ -1224,6 +1224,7 @@ sys_munlock(td, uap)
 	vm_offset_t addr, end, last, start;
 	vm_size_t size;
+	vm_map_t map;
 	int error;
 	error = priv_check(td, PRIV_VM_MUNLOCK);
@@ -1241,7 +1242,9 @@ sys_munlock(td, uap)
 #ifdef RACCT
 	if (error == KERN_SUCCESS) {
-		racct_sub(td->td_proc, RACCT_MEMLOCK, ptoa(end - start));
+		map = &td->td_proc->p_vmspace->vm_map;
+		racct_set(td->td_proc, RACCT_MEMLOCK,
+		    ptoa(pmap_wired_count(map->pmap)));

More information about the svn-src-head mailing list