svn commit: r253215 - head/lib/msun/src

[David Chisnall]

On 11 Jul 2013, at 19:52, Tijl Coosemans <tijl at coosemans.org> wrote:

> GCC doesn't support _Generic yet for -std=c11.

Ugh.  Given that they also lack a fine-grained feature check mechanism, they really should not advertise support for a language dialect if they don't support it.

> 
>> +#elif __GNUC_PREREQ__(5, 1)
> 
> GCC 3.1?

Ooops, I changed this to 5.1 to test the other code path and forgot to revert it.

> Last __fpclassifyd should be __fpclassifyl.

Fixed.

>> @@ -227,8 +250,6 @@ double	expm1(double);
>> double	fma(double, double, double);
>> double	hypot(double, double);
>> int	ilogb(double) __pure2;
>> -int	(isinf)(double) __pure2;
>> -int	(isnan)(double) __pure2;
> 
> I think they should stay for the C90 case.

That would completely defeat the point of this entire exercise and be redundant unless we aim to support a compiler that only supports C90 and no GNU extensions, in which case you'll hit errors in cdefs.h, long before you get to this point in an include.  

David


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 881 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-head/attachments/20130711/0059d114/attachment.sig>