svn commit: r253048 - in head/sys/ofed: drivers/net/mlx4 include/linux

Garrett Cooper yaneurabeya at
Wed Jul 10 23:58:32 UTC 2013

On Tue, Jul 9, 2013 at 8:20 AM, John Baldwin <jhb at> wrote:


> I hadn't seen it.  I had wondered if the '\n' issue was a generic sysfs thing.
> It sounds like it is and I'd be happy to revert the mlx4 change and alter the
> sysfs bits to manage the newline directly if that is more appropriate.

I'll doublecheck this, but basically I'm really adverse to diverging
from Linux in this area -- hence that's why I did what I did in the PR
I mentioned.

> I'd also like this to use sysctl_handle_string() if at all possible.  Are you in
> a position to test patches still?

Unfortunately I'm not right now :(. Anthony may or may not be able to
test this out (I used his machine when we were hacking around on IB

> If so, maybe give this a whirl.  It's similar to yours except it uses
> sysctl_handle_string() and strlcat() rather than continuing to do things
> by hand.  It also outputs an empty string to userland if the attribute
> doesn't have a show method (your version would never pass out an old
> string in that case unlike the original code).

Can you please pass along a patch to Anthony and me so we can try and
apply it to test it out (Gmail's going to taint the inline patch, as
is the EMC Exchange server with the patch attachment)? If Anthony
still has the machine setup, then I'd be more than happy to test out
the patch :).


More information about the svn-src-head mailing list