svn commit: r252375 - head/lib/libfetch

Dimitry Andric dim at
Fri Jul 5 14:39:55 UTC 2013

On Jul 5, 2013, at 10:59, Dag-Erling Smørgrav <des at> wrote:
> Tim Kientzle <kientzle at> writes:
>> Log:
>>  Fix -Wunsequenced warning.
>>  Submitted by:	dt71 at
> Neither approved by nor even discussed with the author and maintainer.
> (not saying it's wrong, but...)

Actually the warning (from clang trunk) was technically wrong, as a
function call is a sequence point.  I reported that upstream, and it got
fixed in the mean time.

That said, the construction still looked a little dodgy, and if the
function call ever gets changed into a macro invocation, there could be
trouble. :-)


More information about the svn-src-head mailing list