svn commit: r252356 - in head: contrib/smbfs/mount_smbfs etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/examples/etc share/mk sys/conf sys/kern sys...
uqs at FreeBSD.org
Wed Jul 3 09:28:08 UTC 2013
On Fri, 2013-06-28 at 21:00:08 +0000, Davide Italiano wrote:
> Author: davide
> Date: Fri Jun 28 21:00:08 2013
> New Revision: 252356
> URL: http://svnweb.freebsd.org/changeset/base/252356
> - Trim an unused and bogus Makefile for mount_smbfs.
> - Reconnect with some minor modifications, in particular now selsocket()
> internals are adapted to use sbintime units after recent'ish calloutng
yay, for reconnecting this to the build. Now Coverity Scan is "seeing"
this code and there are dozens of double frees in the form:
But smb_rq_done() is already calling free(rqp). This seems easy to audit
(sometimes the order is swapped, so it's a USE_AFTER_FREE instead)
This is CIDs 1042109 -- 1042126, all in smbfs_smb.c.
Thanks for looking into this
More information about the svn-src-head