svn commit: r244585 - in head: . sys/geom/label

John Baldwin john at baldwin.cx
Fri Jan 4 17:21:02 UTC 2013


On Saturday, December 22, 2012 08:43:12 AM Jaakko Heinonen wrote:
> Author: jh
> Date: Sat Dec 22 13:43:12 2012
> New Revision: 244585
> URL: http://svnweb.freebsd.org/changeset/base/244585
> 
> Log:
>   Mangle label names containing spaces, non-printable characters '%' or
>   '"'.  Mangling is only done for label names read from file system
>   metadata. Encoding resembles URL encoding. For example, the space
>   character becomes %20.
> 
>   Help by:	kib
>   Discussed with:	imp, kib, pjd

Ouch, mangling spaces seems unfortunate.  I guess fixing the devctl protocol 
is too hard, and/or we can't just encode it at the protocol layer but leave 
the actual device names untouched?  OS X preserves spaces in volume names and 
those can be quite common on ISO images, so mangling them really does seem to 
be a shame if we can avoid it.

-- 
John Baldwin


More information about the svn-src-head mailing list