svn commit: r247300 - in head: sys/sys usr.bin/truss

[Xin Li]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 02/26/13 10:35, John Baldwin wrote:
> On Tuesday, February 26, 2013 12:09:42 pm Davide Italiano wrote:
>> On Tue, Feb 26, 2013 at 3:41 PM, John Baldwin <jhb at freebsd.org>
>> wrote:
>>> On Monday, February 25, 2013 9:13:02 pm Xin LI wrote:
>>>> Author: delphij Date: Tue Feb 26 02:13:02 2013 New Revision:
>>>> 247300 URL: http://svnweb.freebsd.org/changeset/base/247300
>>>> 
>>>> Log: Expose timespec and timeval macros when __BSD_VISIBLE is
>>>> defined.  This allows userland application to use the
>>>> following macros:
>>>> 
>>>> timespecclear, timespecisset, timespeccmp, timespecadd, 
>>>> timespecsub;
>>>> 
>>>> timevalclear, timevalisset, timevalcmp.
>>> 
>>> Why not fix truss to use the stock functions instead of keeping
>>> private "unusual" versions?
>>> 
>>> -- John Baldwin
>> 
>> time.h is already a mess in terms of namespace pollution, and
>> this exposure might not help thing. Other details here: 
>> http://permalink.gmane.org/gmane.os.freebsd.architechture/15518
> 
> I think that is orthogonal.  Even if this is reverted I think truss
> should be changed to use the "normal" timespecsubt() macro rather
> than using a custom one with a different argument order.

I'll find a way to solve this and post a patch for review, thanks for
your comments.

Cheers,
- -- 
Xin LI <delphij at delphij.net>    https://www.delphij.net/
FreeBSD - The Power to Serve!           Live free or die
-----BEGIN PGP SIGNATURE-----

iQEcBAEBCgAGBQJRLQdWAAoJEG80Jeu8UPuzpQ0H/1wxy58rK+p/jx2sZtFIhxCA
j6H/xQ0nNqthVBW2rw0gwiaUgU1AfcAtdfz7/lFopsvbGFoxzQFYUyC4U67JhSk6
IOgElmtjfFMfvj0ksQnEtIGPMYFbc5G4AHfmmwu4f9cjEPBQz3rPssybGqFvJjO+
tUs7I6tYsq5Lnu9ltjDXgBcNHblgjFqz0jMZ/Rysdu4+51Mga5akyV2D6OFbcbNG
oYzC5OOJFvnw6lV+bCVh/ZQNjvEE/Z+YUhfT66MlmU9CBDM9TlYCl7F+5/snZiZ4
0xVFDUIglQqHXkaA1DtP7+HGfVtYhDvO3BgOUe+fHieFxkQFsiEATO4YUImZTKE=
=KUVT
-----END PGP SIGNATURE-----