svn commit: r246720 - head/usr.bin/kdump

Sergey Kandaurov pluknet at freebsd.org
Tue Feb 12 19:37:20 UTC 2013


On 12 February 2013 23:10, Andrey Zonov <zont at freebsd.org> wrote:
> Author: zont
> Date: Tue Feb 12 19:10:54 2013
> New Revision: 246720
> URL: http://svnweb.freebsd.org/changeset/base/246720
>
> Log:
>   - Make actually printing path of AF_LOCAL socket types.
>
>   MFC after:    1 week
>
> Modified:
>   head/usr.bin/kdump/kdump.c
>
> Modified: head/usr.bin/kdump/kdump.c
> ==============================================================================
> --- head/usr.bin/kdump/kdump.c  Tue Feb 12 18:48:11 2013        (r246719)
> +++ head/usr.bin/kdump/kdump.c  Tue Feb 12 19:10:54 2013        (r246720)
> @@ -1492,7 +1492,6 @@ ktrsockaddr(struct sockaddr *sa)
>
>                 memset(&sa_un, 0, sizeof(sa_un));
>                 memcpy(&sa_un, sa, sa->sa_len);
> -               check_sockaddr_len(un);
>                 printf("%.*s", (int)sizeof(sa_un.sun_path), sa_un.sun_path);
>                 break;
>         }
> @@ -1616,8 +1615,7 @@ ktrstruct(char *buf, size_t buflen)
>                 if (datalen > sizeof(ss))
>                         goto invalid;
>                 memcpy(&ss, data, datalen);
> -               if (datalen < sizeof(struct sockaddr) ||
> -                   datalen != ss.ss_len)
> +               if (datalen != ss.ss_len)
>                         goto invalid;
>                 ktrsockaddr((struct sockaddr *)&ss);
>         } else {

Thanks.
For the record, before:
  6436 id       CALL  connect(0x3,0x7fffffffd630,0x14)
  6436 id       STRU  struct sockaddr { AF_LOCAL, invalid }
  6436 id       NAMI  "/var/run/nslcd.ctl"
  6436 id       RET   connect 0
After:
  6436 id       CALL  connect(0x3,0x7fffffffd630,0x14)
  6436 id       STRU  struct sockaddr { AF_LOCAL, /var/run/nslcd.ctl }
  6436 id       NAMI  "/var/run/nslcd.ctl"
  6436 id       RET   connect 0

-- 
wbr,
pluknet


More information about the svn-src-head mailing list