svn commit: r246245 - head/sys/netgraph

Andriy Gapon avg at FreeBSD.org
Mon Feb 4 09:42:39 UTC 2013


on 04/02/2013 10:27 Marko Zec said the following:
> On Monday 04 February 2013 08:41:32 Andriy Gapon wrote:
>> +	/* Only ethernet interfaces are of interest. */
>> +	if (ifp->if_type != IFT_ETHER)
>> +		return;
> 
> 
> And what about IFT_FDDI, IFT_XETHER, IFT_ISO88025, IFT_L2VLAN, IFT_BRIDGE, 
> IFT_ARCNET, IFT_IEEE8023ADLAG, IFT_IEEE80211?

Oh, I didn't realize that many drivers changed if_type after if_alloc.
Honestly, the networking code is not my strong skill, I ventured here only
because nobody else did...

So what do you suggest?  if_alloctype or a different approach?
I'd like to prevent if_l2com being mis-interpreted as struct arpcom.

-- 
Andriy Gapon


More information about the svn-src-head mailing list