svn commit: r259896 - head/sys/dev/cxgb/common

Pedro Giffuni pfg at FreeBSD.org
Sun Dec 29 20:51:41 UTC 2013


On 26.12.2013 06:13, Dimitry Andric wrote:
> On 26 Dec 2013, at 02:51, Adrian Chadd <adrian at freebsd.org> wrote:
>> I'd prefer you didn't remove unused code in drivers like this. If you
>> must, #if 0 them out.
> I don't mind either way, but some other people are very much opposed to
> littering code with #if 0'd sections.  So, how do to determine what is
> right in each situation? :-)
>

FWIW, I am also in favor of removing instead of #if 0.
If we really need the code back, we have subversion for that.

I guess an exception would be on contributed code, where one
still wants to keep things similar.

Just my 0.02$, no strong feelings about either way.

Pedro.



More information about the svn-src-head mailing list